Submitted over 1 year ago

Product Preview Card (Simple Setup)

Muhammad Alkahfi Khuzaimy Abdullah• 60

@alcoffeeocha

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

Product preview card component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

Hi! Thanks for viewing my project. I don't know which is better to give spaces between two elements, is it by using margin-top or margin-bottom, and to what element? Anyway, I love whatever feedback for this😊

Community feedback

Hassia Issah• 50,670

@Hassiai

Posted over 1 year ago

Replace <div class="card"> with the main tag to fix the accessibility issues. click here for more on web-accessibility and semantic html

There is no need to give .card margin: 0 auto.

Hope am helpful.

Well done for completing this challenge. HAPPY CODING

Muhammad Alkahfi Khuzaimy Abdullah• 60

@alcoffeeocha

Posted over 1 year ago

@Hassiai Okay, will update soon. Thank you!

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord