@0xabdulkhaliq
Posted
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have a suggestion regarding your code that I believe will be of great interest to you.
HTML 🏷️:
- I need to address a minor semantic improvement which may help accessibility devices to properly announce the old price of the perfume.
- Currently the old price is not being properly announced, you have used
span
element for that withtext-decoration: line-through
css property.
- Instead of customizing
span
there's actually a native semantic html element which comes handy in these situations. it isdel
element
- So you can use like this
<del>$169.99</del>
- These are the tips which improves the accessibility in real world situations.
- If you have any questions or need further clarification, you can always check out
my submission
and/or feel free to reach out to me.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful
@gmagnenat
Posted
Hi @0xabdulkhalid thanks a lot for checking out my solution and thank you for the tip !
@gmagnenat
Posted
@0xabdulkhalid I updated my solution with your suggestion. Thanks again for the tip 👍 !
@0xabdulkhaliq
Posted
You're welcome @gmagnenat !