Design comparison
Solution retrospective
What did you find difficult while building the project? border the same in 2 div's, and size div to 100% Do you have any questions about best practices? i think i can use more option from sass
Community feedback
- @correlucasPosted about 2 years ago
πΎHello Matt, congratulations for your new solution!
Your solution is really fine and I liked a lots this salmon color you've added to the background, this gives a special touch. A quick fix for the border-radius for the entirely container is to add the
border-radius: 12px
to the class that wrap the two divs andoverflow: hidden
to make the image gets the border-radius too, or add theborder-radius
to the two borders the image needs.A best practice for this challenge is using
<picture>
for the images, instead of using a class to place the image using the css, you can manage the product image inserting the tag<picture>
to wrap both desktop and mobile images together in the same tag, and render each image depending of the device (phone / computer) by the settings for the width you'll insert in the htmlπ I hope this helps you and happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord