product preview card reponse

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted over 2 years ago

  👾Hello Matt, congratulations for your new solution!

  Your solution is really fine and I liked a lots this salmon color you've added to the background, this gives a special touch. A quick fix for the border-radius for the entirely container is to add the border-radius: 12px to the class that wrap the two divs and overflow: hidden to make the image gets the border-radius too, or add the border-radius to the two borders the image needs.

  A best practice for this challenge is using <picture> for the images, instead of using a class to place the image using the css, you can manage the product image inserting the tag <picture> to wrap both desktop and mobile images together in the same tag, and render each image depending of the device (phone / computer) by the settings for the width you'll insert in the html

  👋 I hope this helps you and happy coding!

  0