Product preview card - Mobile first

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey @GSD3v08, some suggestions to improve you code:

  • The Alt Tag description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image/icon to someone.

  • The old price isnt being announce properly to screenreaders. You want to include a sr-only text explaining that this is the old price.

  • Start your media query a lot later, maybe at 600px. That way it takes up more space on tablets.

  • Your CSS Reset is extremely bare. You want to add more to it.

  Here are few CSS Resets that you can look at and use to create your own CSS Reset or just copy and paste one that already prebuilt.

  https://www.joshwcomeau.com/css/custom-css-reset/

  https://meyerweb.com/eric/tools/css/reset/

  http://html5doctor.com/html-5-reset-stylesheet/

  Happy Coding!

  Marked as helpful

  0

  ---

  

  GSD3v08•190

  @GSD3v08Posted about 2 years ago

  @vcarames , thank you for your suggestions I really appreciate it, I'll have to learn more about CSS Reset.

  0