Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product Preview Card mobile and desktop

Abaso 90

@originalboss

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any tips?

Community feedback

Daniel 🛸 44,230

@danielmrz-dev

Posted

Hello @originalboss!

Your solution looks great!

I have a suggestion for improvement:

  • For semantic reasons, only use one <h1> per page - this should represent the main heading/subject for the whole page.

The <h1> to <h6> tags are used to define HTML headings. <h1> defines the most important heading. <h6> defines the least important heading. And do not skip heading levels - start with <h1>, then use <h2>, and so on.

  • For the same reasons, use p for paragraphs instead of span.

  • And maybe check BEM methodology for naming classes. I have to say, I know you mean button, but that div.butt had me laughing 🤣

I hope it helps!

Other than those details, you did a great job!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord