Product Preview Card (HTML + CSS)

Community feedback

• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  PiCTURE TAG 📸:

  • Looks like you're currently using media queries for swapping different version of image, So let me introduce the picture element.

  ---

  • The <picture> tag is commonly used for responsive images, where different image sources are provided for different screen sizes and devices, and for art direction, where different images are used for different contexts or layouts.

  ---

  • Example:

  <picture>
  <source media="(max-width: 768px)" srcset="small-image.jpg">
  <source media="(min-width: 769px)" srcset="large-image.jpg">
  <img src="fallback-image.jpg" alt="Example image">
  </picture>
  

  ---

  • In this example, the <picture> tag contains three child elements: two <source> elements and an <img> element. The <source> elements specifies different image sources and the conditions under which they should be used.

  ---

  • Using this approach allows you to provide different images for different screen sizes without relying on CSS, and it also helps to improve page load times by reducing the size of the images that are served to the user

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  Lucas Exequiel•200

  @arrejoriaPosted over 1 year ago

  Hey, good job on this solution! 💯 I can leave you some tips.

  Media queries are great and it is very important to always use them at the end of your style code or selector to give them more importance. ☝️

  I note the layout lost styles for others resolutions, the reason of that is that you use css properties that are important for the visual design in your media queries. For example you could use only media queries to resize or handle the containers or content box like image-container and info-container.

  You are doing great! 🧉

  0
• 

  Adel•820

  @Adel-HarratPosted over 1 year ago

  Great, and the spacing between elements needs a bit more love, Happy Coding xD

  0