Product preview card (HTML, CSS, Responsive)

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component.

  body {
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  .container {
  margin: auto;
  margin-top: 150px;
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Teri•30

  @teriappPosted over 1 year ago

  @0xAbdulKhalid thank you very much, this worked.

  0
• 

  XIII•790

  @minibruspPosted over 1 year ago

  there are two options i can give to you

  • adding these styles to p.saleprice class

  display: flex; justify-content: flex-start; align-items: center; gap: 1rem;

  • restructuring the html for div.price making both p.saleprice and span.oldprice as siblings then adding the above styles to div.price

  Marked as helpful

  1

  ---

  

  Teri•30

  @teriappPosted over 1 year ago

  @minibrusp this worked, thank you.

  0
• 

  Byomugisha Mackson•200

  @mack14Posted over 1 year ago

  i think you can target the old price and give it some bottom padding or if it is in the div you can tex align in center.

  Marked as helpful

  1