Design comparison
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
-
To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the
Main
Element. -
The
Alt Tag
description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image to someone. -
Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a
Del
element and inside it you will add aSpan
element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers. -
Implement a Mobile First approach 📱 > 🖥
With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🍂🦃
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord