Skip to content
Submitted almost 2 years ago

[Desktop] Product Preview Card - Gabrielle Perfume

Anelise Paz•30
@anepaz
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Here is my take on the product preview card challenge - desktop version. I would love to get some feedback on the CSS, especially on the use of flexbox. Would also appreciate some feedback on code structure in relation to best practices. Thanks!

Community feedback

  • Rennan Silva•190
    @Rennan20Posted almost 2 years ago

    Overall, it's good. Since you requested feedback on some best practices, it's recommended to set the margin and padding of the entire page to 0. Using border-box will also allow for better manipulation of proportions, which is important since the website is supposed to be responsive. Using rem instead of px is also a good idea. I hope this helps. You can check my code for reference."

    Marked as helpful
    0
    Anelise Paz•30
    @anepazPosted almost 2 years ago

    @Rennan20 Thanks for the feedback! I'll keep them in mind for my next challenge.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord