Design comparison
Solution retrospective
What tips can you give? What did I do well, what can I improve on?
Community feedback
- @danielmrz-devPosted 11 months ago
Hello @originalboss!
Your project looks great!
I have a very useful tip for you:
- I see that you used the tag
img
to insert the image on the project. In this case, you could've left yourdiv.card
empty on HTML and insert the image as abackground
with CSS. By doing that, you have more flexibility on manipulating the image size and position.
I hope it helps!
Other than that, you did an excelent job!
Marked as helpful0 - I see that you used the tag
- Account deleted
This comment was deleted 11 months ago
0@originalbossPosted 11 months ago@davood-webdev
Thank you for the advice, but there are a couple of things I want to say
-I didn't know about the picture tag so thank you for telling me about it -I didn't know about the desktop design problem I tried on two different designs, and it looked fine, but once again thank you for bringing this to my attention. -I skipped the mobile design on purpose for now I'm just trying to practice the easy parts of coding I will get into media queries and stuff like that later. -I don't know what's wrong with the font-family I got that one from the readme-template.
Anyway, thank you for all of the advice, I am grateful for people like you who can give me the feedback I need.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord