Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product Preview Card Desktop Version

Abaso 90

@originalboss

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What tips can you give? What did I do well, what can I improve on?

Community feedback

Daniel 🛸 44,230

@danielmrz-dev

Posted

Hello @originalboss!

Your project looks great!

I have a very useful tip for you:

  • I see that you used the tag img to insert the image on the project. In this case, you could've left your div.card empty on HTML and insert the image as a background with CSS. By doing that, you have more flexibility on manipulating the image size and position.

I hope it helps!

Other than that, you did an excelent job!

Marked as helpful

0

Account Deleted

This comment was deleted

0

Abaso 90

@originalboss

Posted

@davood-webdev

Thank you for the advice, but there are a couple of things I want to say

-I didn't know about the picture tag so thank you for telling me about it -I didn't know about the desktop design problem I tried on two different designs, and it looked fine, but once again thank you for bringing this to my attention. -I skipped the mobile design on purpose for now I'm just trying to practice the easy parts of coding I will get into media queries and stuff like that later. -I don't know what's wrong with the font-family I got that one from the readme-template.

Anyway, thank you for all of the advice, I am grateful for people like you who can give me the feedback I need.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord