Design comparison
SolutionDesign
Solution retrospective
-
pixel perfect preview was my first priority. Detailed positioning took a lot of effort. 😫
-
i revised some colors to create more modern look. 👌
-
i added dark mode support with css. 😊
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here is some feedback to further improve your code:
- The image’s
alt tag
description needs to be improved upon ⚠️. Assume that you are describing the image to someone over the phone.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- Do not uppercase ❌ "perfume" in HTML as it is not accessible friendly. Instead you will want to style it in CSS.
- The old price (169.99) 🏷 is not being properly announced 😢 to screen readers. To fix this, inside the
del
element you will want to add aspan
element with anvisually-hidden
class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.
If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.
Happy Coding! 👾
1@bilalturkmenPosted almost 2 years ago@vcarames hi Valentine, thanks for your feedback. i got them done 🙌
0 - The image’s
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord