Design comparison
SolutionDesign
Community feedback
- @Islandstone89Posted 10 months ago
Hi Sabina, good job! Here are some suggestions.
HTML:
- Text should never be in divs alone.
.product-description
andfirst-cost
both need to be wrapped in a<p>
.
CSS:
-
Performance-wise, it's better to link fonts in the
<head>
of the HTML than using@import
. -
You don't need to give
html
andbody
aheight: 100%
. Instead, give thebody
amin-height: 100vh
so the content is allowed to grow without causing overflow. Also, since the card is centered using Grid, you can remove the margin. -
font-size
must never be in px. This is bad for accessibility, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead. -
letter-spacing
must also never be inpx
.
Marked as helpful0 - Text should never be in divs alone.
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord