Design comparison
Solution retrospective
Hello Frontend Mentor Community! This here is my second Frontend Mentor project, using only html and css (sass preprocessor). In this project, I was focusing more on using Semantic HTML above everything else. Also, this was my first time attempting to use media query to make a website that is responsive to mobile view. Any feedback on best practices for Semantic HTML and mobile first design would be greatly appreciated. Thank y'all !
Community feedback
- @mukwende2000Posted over 1 year ago
Great solution, congratulations, as regards your question on accessibility, the entire app should be wrapped in a <main></main> tag not an article. I thing the word 'Perfume' should be the h1 and then the name of the perfume an h2. Lastly instead of hiding on picture on mobile and showing it on desktop using css, you can use the <picture></picture> tag, read about it, it is more concise.
Marked as helpful1@ebarreto-mendozaPosted over 1 year agoThank you for your feedback! I looked into the <main> </main> tag and I absolutely agree that the app should be wrapped within it. I remember having read something about the <picture></picture> tag before but in the moment I forgot was it was called, thank you for mentioning it. I went ahead and implemented the feedback into the project. Once again, thank you! @mukwende2000
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord