Product preview card components solution

Community feedback

• 

  Joachim•840

  @Thewatcher13Posted over 1 year ago

  • Why did you use the sup tag on your old price?
  • On decorative pictures/icons should be no alt text
  • Your button has no type (type:button)
  • Why did you used the images as background?

  0

  ---

  

  P

  Ghenu Andreea Daniela•130

  @danyela2000Posted over 1 year ago

  @Thewatcher13

  • A button element outside of a form has type=button as its default value.
  • Since the left image was purely decorative, I decided to use it as a background image instead of using it as an img element.
  • For the rest, I corrected them.

  0

  

  Joachim•840

  @Thewatcher13Posted over 1 year ago

  • A button element outside of a form has type=button as its default value.

  that's not right.

  On the w3c source you can see that if the type attribute is missing the default type=submit. https://www.w3.org/TR/2011/WD-html5-20110525/the-button-element.html#attr-button-type

  You can see this on your site in the devtools.

  Go to devtools>first select elements tab (select your button element)>now on the other part go to property's> scroll untill you see "type"> change your type of the button and you see that is standard "submit".

  0

  

  P

  Ghenu Andreea Daniela•130

  @danyela2000Posted over 1 year ago

  @Thewatcher13 It means I understood wrong the default type of the button element. 😅 Perhaps some versions of browsers have this default type for buttons. Thanks for correction.

  0

  

  Joachim•840

  @Thewatcher13Posted over 1 year ago

  You're welcome!

  0