Product preview card component

Community feedback

• 

  Boris•2,870

  @mkborisPosted 2 months ago

  Great work @deusdeteneto, here are a few things to review

  • To handle responsive images effectively you can use the picture element. This allows you to specify different images for various screen sizes and resolutions. Using CSS to hide and show images to display differently on various screen sizes is not part of the best practices.
  • It's best practice linking Google fonts directly in the HTML head section rather than directly in your CSS file as it enables asynchronous downloading, improving page load times.
  • Media queries should be defined in rem not px
  • Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset. This will help reset a list of default browser styles.
  • Font-size should be written in rem not px. This article explains it better Why font-size must NEVER be in pixels.
  • Use a class instead of an ID for styling to keep specificity low, reserve IDs for JavaScript manipulation.

  Marked as helpful

  1

  ---

  

  Neto•190

  @deusdetenetoPosted 2 months ago

  Thank you very much @mkboris for the feedback! I really wasn’t aware of all these practices. I read the articles you mentioned and found them very enlightening. I will review this entire structure at some point or redo it with a fresh perspective and more experience.

  1