Product Preview Card Component

Community feedback

• 

  Erel Ropeta•385

  @ereljapcoPosted over 2 years ago

  Hey, MirTynan!

  Try to use rem. 0.65rem worked for mine :)

  And if I may add some suggestions:

  Re: accessibility

  • You can wrap your container inside main.
  • You can add alt="Add a description here" for the image

  Re: style

  • You can use flexbox on main to place your item in the center of the viewport. Consider setting your height to 100vh
  • You can add the font-family that is in the style-guide.md

  Marked as helpful

  0
• 

  Leo•440

  @SouiciaPosted over 2 years ago

  Hello MirTynan, how we meet again ! :)

  For border-radius, do not use percentage, use px. The only time you use percentage in border-radius is when you make a circle and it's always 50% with the same width and height. Otherwise, when you style more precisely, such as this challenge, use px.

  Also, avoid using the <h> tag to make your text bigger, the <h> tag is reserved for title of sections on a website and should be used in decreasing order and in big websites. You can easily change the font-size, and weight with those CSS attributes while using the <p> tag or a <div>.

  Marked as helpful

  0

  ---

  

  MirTynan•100

  @MirTynanPosted over 2 years ago

  @Souicia thank you! Coming to save me again :)

  2
• 

  Daramola Ayokunle Victor•30

  @Victolo1Posted over 2 years ago

  Have your tried using the border-radius property?

  0

  ---

  

  MirTynan•100

  @MirTynanPosted over 2 years ago

  @Victolo1 yes but it just seems to give an angle instead of a curve The border radius worked on the container itself but for some reason not the button

  0