Design comparison
SolutionDesign
Solution retrospective
This is my first challenge at frontendmentor. any comment is appreciated
Community feedback
- @frank-itachiPosted almost 2 years ago
Hello there 👋. You did a good job!
I have some suggestions about your code that might interest you.
HTML 📄:
- Wrap the page's whole main content in the
<main>
tag. - If your code has different sections that have a specific purpose like a navigation, article, sections or footer, it’s a good practice to enclose those parts with HTML5 landmarks. For example, you could use a
<footer>
tag to wrap the<div class=”attribution”>
section. - The heading order is important in the html structure so try to always start your headings with an
<h1>
tag and then you can decrease by one if you need to use more heading in your html code.
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy
<coding />
😎!0 - Wrap the page's whole main content in the
- @oyeyinkaojoraPosted almost 2 years ago
Hi Sasan, You should make your card container responsive,I just checked the link and found out it’s not mobile responsive .You can use flex and media query to handle the mobile responsive , Learn Flex box via this Youtube tutorial
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord