Product preview card component

Community feedback

• 

  Divine Obeten•2,415

  @Deevyn9Posted about 2 years ago

  Hi Lazar, congrats on completing this project. The images aren’t appearing, should be a directory issue. Try getting it fixed.

  Happy coding!

  Marked as helpful

  2

  ---

  

  Lazar Ristic•80

  @lazza24Posted about 2 years ago

  @Deevyn9 Hello, thank you for your feedback and advice. Not sure why image isn't showing app. maybe github pages not allowing in free package?

  1

  

  Divine Obeten•2,415

  @Deevyn9Posted about 2 years ago

  @lazza24 try adding a “.” before the “/“ in the image src

  Marked as helpful

  1

  

  Lazar Ristic•80

  @lazza24Posted about 2 years ago

  @Deevyn9, problem solved!

  Thank You very much!

  1
• 

  Adriano•38,120

  @AdrianoEscarabotePosted about 2 years ago

  Hi Lazar Ristic, how are you?

  I really liked the result of your project, but I have some tips that I think you will enjoy:

  • images must have alt text unless it is a decorative image, for any decorative image each IMG tag must have empty alt="" and add aria-hidden="true" attributes to make all the assistive technologies of the Web, as screen reader. Learn the differences between decorative/meaningless images vs important content.
  • every Html document must contain the main tag, so we can identify the main content, to fix this, wrap all the content with the main tag. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.
  • To align some content in the center of the screen, always prefer to use display: flex; it will make the layout more responsive!

  Example:

  body {
      margin: 0;
      padding: 0;
      display: flex;
      align-items: center;
      justify-content: center;
      min-height: 100vh;
  }
  

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  1

  ---

  

  Lazar Ristic•80

  @lazza24Posted about 2 years ago

  @AdrianoEscarabote , thank you for your time and help!

  Sure it's help a lot.

  Best regards!

  0

  

  Adriano•38,120

  @AdrianoEscarabotePosted about 2 years ago

  @lazza24 happy coding!!

  0
• 

  Samuel Mantey Asare-Adjei•40

  @sam-manteyPosted about 2 years ago

  Hello Lazar Ristic. You have done a great job so far.

  Try using the <picture> tag when you need to change images based on different devices. This prevents the web browser from loading both images and hence reducing bandwidth.

  **Example

          <picture>
            <source  media="(min-width: 625px)" srcset="images/image-product-desktop.jpg">
            <img  src="images/image-product-mobile.jpg" alt="">
          </picture>
  

  0