Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product preview card component

@lazza24

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


The biggest challenge was to change the image while using @media queries. The solution was to put both images on mobile size with two classes and use display none depending of size

Community feedback

Divine Obeten 2,415

@Deevyn9

Posted

Hi Lazar, congrats on completing this project. The images aren’t appearing, should be a directory issue. Try getting it fixed.

Happy coding!

Marked as helpful

2

@lazza24

Posted

@Deevyn9 Hello, thank you for your feedback and advice. Not sure why image isn't showing app. maybe github pages not allowing in free package?

1
Divine Obeten 2,415

@Deevyn9

Posted

@lazza24 try adding a “.” before the “/“ in the image src

Marked as helpful

1

@lazza24

Posted

@Deevyn9, problem solved!

Thank You very much!

1
Adriano 34,090

@AdrianoEscarabote

Posted

Hi Lazar Ristic, how are you?

I really liked the result of your project, but I have some tips that I think you will enjoy:

  • images must have alt text unless it is a decorative image, for any decorative image each IMG tag must have empty alt="" and add aria-hidden="true" attributes to make all the assistive technologies of the Web, as screen reader. Learn the differences between decorative/meaningless images vs important content.
  • every Html document must contain the main tag, so we can identify the main content, to fix this, wrap all the content with the main tag. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.
  • To align some content in the center of the screen, always prefer to use display: flex; it will make the layout more responsive!

Example:

body {
    margin: 0;
    padding: 0;
    display: flex;
    align-items: center;
    justify-content: center;
    min-height: 100vh;
}

The rest is great!

I hope it helps... 👍

Marked as helpful

1

@lazza24

Posted

@AdrianoEscarabote , thank you for your time and help!

Sure it's help a lot.

Best regards!

0
Adriano 34,090

@AdrianoEscarabote

Posted

@lazza24 happy coding!!

0

@sam-mantey

Posted

Hello Lazar Ristic. You have done a great job so far.

Try using the <picture> tag when you need to change images based on different devices. This prevents the web browser from loading both images and hence reducing bandwidth.

**Example

        <picture>
          <source  media="(min-width: 625px)" srcset="images/image-product-desktop.jpg">
          <img  src="images/image-product-mobile.jpg" alt="">
        </picture>
0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord