Responsive Flex Grid Css

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  Congrats on completing your first challenge!🎊🎆

  • Do not capitalize "perfume" in HTML as it is not accessible friendly. Instead you will want to style it in CSS.

  • The only heading in this component, is the name of the perfume; “Gabrielle Essence Eau De Parfum” . The rest of the text should be wrapped in a paragraph element.

  • Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a del element and inside it you will add a span element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

  More Info:📚

  Del Element

  • The image’s alt tag description needs to be improved upon to better describe what it is. You will want to assume that you are describing the image to a someone.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • This component requires the use of two images 🎑 at different breakpoints. The picture element will facilitate this.

  Here is an example of how it works: EXAMPLE

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:📚

  https://www.w3schools.com/html/html_images_picture.asp

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  Marked as helpful

  0

  ---

  

  Waldo•250

  @Waldo3333Posted almost 2 years ago

  @vcarames Thanks for your feedback :) , i'm currently working on an other challenge, as soon as i'm done whit it, i'll make improvement on this one ! Thanks

  0
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  the logo is in the images folder in the zip folder you downloaded is a svg file and in color white , when you open the svg file you will find it empty but its there. hope you find it

  Replace <div class="box"> with the main tag, <h4> with <p> <h3> with <h1> and <h5> with <p> to fix the accessibility issues.

  Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on this watch this https://youtu.be/N5wpD9Ov_To

  To center .box on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  Hope am helpful. HAPPY CODING

  Marked as helpful

  0

  ---

  

  Waldo•250

  @Waldo3333Posted almost 2 years ago

  @Hassiai Thanks a lot for your feedback, I appreciate ! I'll try this !

  0