Frontend Mentor | Product preview card component coding challenge solution

Community feedback

@correlucas

Posted about 2 years ago

👾Oi Gelcimar Moraes, tudo bem? Parabéns pelo desafio!

Acabei de ver sua solução e tenho umas dicas pra melhorar seu código/design:

1.A sua solução ficou muito boa, a estrutura html o design também, algo que você pode fazer para melhorar a imagem que precisa mudar entre mobile e desktop é usar <picture> ao invés de <img> dentro de uma div. Por motivos de SEO e mecanismos de pesquisa tipo Google e bing, não é uma boa prática importar esta imagem do produto com CSS, pois isso dificultará a localização da imagem no google. Você pode gerenciar ambas as imagens dentro da tag <picture> e usar o código html para definir quando as imagens devem mudar configurando o dispositivo max-width dependendo do dispositivo (mobile / desktop) Aqui está um guia sobre como usar picture: https://www.w3schools.com/tags/tag_picture.asp

2.Pra reduzir o seu código e deixar o arquivo de CSS muito leve e melhorar o carregamento da página você pode usar essa ferramenta chamada CSS Minify que reduz o código css removendo caracteres desnecessários. https://www.toptal.com/developers/cssminifier

👋 Espero que essas dicas te ajudem e que você continue no foco!

Marked as helpful

Gelcimar Moraes• 150

@GelcimarMoraes

Posted about 2 years ago

@correlucas Thank you very much, your tips are helping me a lot, I will follow your recommendations.

Adriano• 37,910

@AdrianoEscarabote

Posted about 2 years ago

Hi Gelcimar Moraes, how are you?

I really liked the result of your project, but I have some tips that I think you will like:

1- Every page should have one main landmark <main>. So replace the div that wraps the whole content with <main> to improve the accessibility. click here

2- All page content should be contained by landmarks, you can understand better by clicking here: click here

We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

Example:

native HTML5 reference elements:

<body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

<body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

Link to read more about: click here

2- Why it Matters

Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.

HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.

Rule Description

It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.

Link to read more about: click here

The rest is great!!

Hope it helps...👍

Marked as helpful

Gelcimar Moraes• 150

@GelcimarMoraes

Posted about 2 years ago

@AdrianoEscarabote Thank you very much, I will follow your recommendations.

Product preview card component

Design comparison

Community feedback

Please log in to post a comment

Join our Discord community