Product preview card component

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey @digitallimat, some suggestions to improve you code:

  • Apply the following code to have each side take up the equal amount.

  Code:

  .card > * {
          flex-basis: 50%
      }
  

  • The Alt Tag Description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image to someone.

  • The old price 🏷 is not being announced properly to screen readers. You want to wrap it in a Del Element and include a sr-only text explaining that this is the old price.

  • Your "button" was created with the incorrect element. It should be created using the Button Element. So that when the user clicks on the button (with the help of JS) it should add the product to the cart.

  • Implement a Mobile First approach 📱 > 🖥

  With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.

  Happy Coding! 👻🎃

  Marked as helpful

  1
• 

  Vijay K Naik•940

  @KruzadeR-VictoRPosted about 2 years ago

  Hi Jeeva,

  you may consider the following changes :

  1. the accesibility issue is due to the h2 tag you have used for the heading of the product,you should use h1 tag to avoid the issue. For more details check https://dequeuniversity.com/rules/axe/4.1/page-has-heading-one
  2. card container is not centered in larger screens due to the max-width property you've set to the container
  3. And the product details page should contain half of the card and so is the product image
  4. You need to also check the typography for bigger screens like the 'perfume' and the 'description' part

  Otherwise you've done a pretty good job on mobile part, Happy coding .. Ty

  Marked as helpful

  0