Product preview card component witth just CSS and HTML

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The Alt Tag Description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image to someone.

  • This challenges requires the use of two images 🎑 for different breakpoints. The Picture Element will facilitate this.

  Here is an example of how it works: EXAMPLE

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:

  https://www.w3schools.com/html/html_images_picture.asp

  https://web.dev/learn/design/picture-element/

  • The name of the perfume , “Gabrielle Essence Eau De Parfum” is the most important content in your card so it should be wrapped in a Heading Element.

  • The old price 🏷 is not being announced properly to screen readers. You want to wrap it in a Del Element and include span element with an sr-only text explaining that this is the old price.

  Happy Coding! 👻🎃

  Marked as helpful

  0

  ---

  

  Cintia•100

  @ciisiqPosted about 2 years ago

  @vcarames Thank you so much for the tips 🙌🏻 I'll check this and improve!!

  0
• 

  AK_07•60

  @aarsh07Posted about 2 years ago

  Hello Cintia , how are you ?

  Your design is pretty good but you should give a breakpoint at 750px for mobile screen because it is overflowing in mobile design so check that

  Marked as helpful

  0

  ---

  

  Cintia•100

  @ciisiqPosted about 2 years ago

  @aarsh07 Thank you for your feedback I will change this =D

  1
• 

  Adriano•38,290

  @AdrianoEscarabotePosted about 2 years ago

  Hi Cintia, how are you?

  Welcome to the front-end mentor community!

  I really liked the result of your project, but I have some tips that I think you will enjoy:

  • every Html document must contain the main tag, so we can identify the main content, to fix this, wrap all the content with the main tag. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.
  • Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  0

  ---

  

  Cintia•100

  @ciisiqPosted about 2 years ago

  @AdrianoEscarabote Thank you Adriano for your time give me feedback I will improve the code with your tips, thank you !!

  0

  

  Adriano•38,290

  @AdrianoEscarabotePosted about 2 years ago

  @ciisiq no problem, keep coding!!

  0