Design comparison
SolutionDesign
Solution retrospective
Hello, this is my second task. Please feel free to leave your comment and review the code. Please let me know is this correct way to position my footer element?
Community feedback
- @hernanruscicaPosted about 2 years ago
Hello WhiteFatal, this solution is great, I liked it a lot. The result solution seams to be the same to the disegn. Analyzing the code, I can tell you that:
- As you say, I think you gave too much importance to the "footer", when it was not the main thing. Besides that code should be more simple, it was not necessary that you position it in each "media query". On the other hand, if you had started "mobile first" you would have done it with a single "media query". On the other hand, it is good practice to separate the HTML from the CSS code. Overall, an excellent job, I hope you continue on the platform. I'm starting too and I think it's very good. Greetings.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord