Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product preview card component with CSS Grid and Flexbox

Jason Konradโ€ข 60

@AzpenMeadows

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I am still new to html/CSS. Any feedback is appreciated!

Community feedback

@MelvinAguilar

Posted

Hello there ๐Ÿ‘‹. Good job on completing the challenge !

I have some suggestions about your code that might interest you.

  • The alt attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.

  • You can use the <picture> tag when you have different versions of the same image ๐Ÿ–ผ. Using the <picture> tag will help you to load the correct image for the user's device saving bandwidth and improving performance. You can read more about this here ๐Ÿ“˜.

    Example:

    <picture>
        <source media="(max-width: 460px)" srcset="./images/image-product-mobile.jpg">
        <img src="./images/image-product-desktop.jpg" alt="{your alt text goes here}">
    </picture>
    
  • Use min-height: 100dvh instead of height. Setting the height to 100dvh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.

I hope you find it useful! ๐Ÿ˜„ Above all, the solution you submitted is great!

Happy coding!

Marked as helpful

0

Jason Konradโ€ข 60

@AzpenMeadows

Posted

@MelvinAguilar

Thank you for the advice! I did not know about the picture element. I will learn more about that.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord