Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product preview card component

@faizan619

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@VCarames

Posted

Hey there! 👋 Here are some suggestions to help improve your code:

  • To better identify the main content of you site you will want to encase your entire component inside a Main Element.

  • The Alt Tag Description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image to someone.

  • This challenges requires the use of two images 🎑 for different breakpoints. The Picture Element will facilitate this.

Here is an example of how it works: EXAMPLE

Syntax:

  <picture>
    <source media="(min-width: )" srcset="">
    <img src="" alt="">
  </picture>

More Info:

https://www.w3schools.com/html/html_images_picture.asp

https://web.dev/learn/design/picture-element/

If you have any questions or need further clarification, let me know.

Happy Coding! 👻🎃

0
Declan 220

@engelbrechtz

Posted

Hey, hows it going.

Looks really good!

Changes to consider

  • Apply the background colour which was provided to you in you're style-guide.md file. use this colour for the background hsl(30, 38%, 92%)
  • Remove margin-bottom: 2rem from rate div and add margin-top: 50px; to the rate div.

Apply these changes to the #para

font-size: 1.2rem; color: lightgrey; line-height: 25px; font-family: sans-serif; } Make sure short classes like #para also known as paragraph are meaningful and readable class names.

Apply these changes to right-up-content h1 margin: 0; width: 90%; font-size: 40px;

Make sure to add these font familes to you're css and apply to replicated design. Montserrat Fraunces

Everything else seems to be good.

Keep coding, Regards.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord