Design comparison
Solution retrospective
If anyone has any feedback on things I could do better, let me know!
One question - what should I replace the margin-right with on the add to card img so that on smaller screens the text doesn't stack?
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
-
The image’s
Alt Tag
description needs to be improved upon to better describe what it is. You will want to assume that you are describing the image to a someone. -
This component requires the use of two images 🎑 at different breakpoints. The
Picture
element will facilitate this.
Here is an example of how it works: EXAMPLE
Syntax:
<picture> <source media="(min-width: )" srcset=""> <img src="" alt=""> </picture>
More Info:
https://www.w3schools.com/html/html_images_picture.asp
https://web.dev/learn/design/picture-element/
- Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a
Del
element and inside it you will add aSpan
element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🍂🦃
Marked as helpful1 -
- @ilonka011Posted about 2 years ago
This looks amazing! I myself just posted the project. I actually tried using the fonts that were provided but for some reason the main and the most beautiful one looks like it's the wrong one. I wish I could solve that problem. Your end product is almost identical to what it originally was. I'm so impressed and also motivated by your work! Keep it up.
Marked as helpful1@MlchaellPosted about 2 years ago@ilonka011 Thank you! I'll look through it later if you haven't already fixed it and see if I can help, you can also read through my version of the code and see if that helps you
0@ilonka011Posted about 2 years ago@Mlchaell Thanks a lot and wish you all the best in continuing to learn!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord