Product preview card component using Sass
Design comparison
Solution retrospective
During this project, I reviewed some concepts related to designing responsive layouts and working with images.
What challenges did you encounter, and how did you overcome them?Overall, the project was manageable.
What specific areas of your project would you like help with?I'm open for reviews and suggestions.
Community feedback
- @Zub04ekPosted 3 months ago
Greetings, @IncorrigibleSpirit, you have completed this challenge with an excellent result š
I can only add that you can hide the unnecessary vertical scroll by removing margin from body or replacing it with
margin: 0 auto;
I discovered some new concepts of using sass from your code, keep going!
Marked as helpful0@IncorrigibleSpiritPosted 3 months agoHi there! Thank you for your suggestion. Good point! I will add it to my code using a media query. Why? On small devices, I will keep the margin.
Happy coding! @Zub04ek
1 - @Jaimealicante83Posted 3 months ago
Hi Carlos,
Your solution looks very similar to the design. I would just modify a couple of things.
I have a few suggestions: Iād recommend checking the line-height of the card title as it seems to be a bit off compared to the Figma design.
You might want to consider removing the margin-top and margin-bottom on the body, as this causes the layout to be slightly misaligned vertically compared to the design.
Lastly, while the button shadow looks cool, it might be better to match it more closely with the original design.
Cheers!
Marked as helpful0@IncorrigibleSpiritPosted 3 months agoHola, @Jaimealicante83 ! As the saying goes, life is made up of small details! I really value your feedback. I've made some subtle changes based on your comments.
Regarding the margin, I've decided to use another media query to enhance the desktop version. However, I still think it's important to keep the margin for the mobile one.
Happy coding!
0 - @NegligencePosted 3 months ago
The only minor thing that I've noticed is the applied color to
.card-title
It's currently set to
color: #000000;
and should instead use
color: hsl(212, 21%, 14%);
But aside from that, it looks perfect in my eyes to be honest, great job šš»
0@IncorrigibleSpiritPosted 3 months agoHi @Negligence ! Thank you for reviewing my code and leaving your feedback. As you mentioned, that minor detail doesn't adhere to the guidelines! Sometimes I feel like adding a personal touch. LOL
Thanks anyway! :D and Happy coding!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord