Product Preview Card Component using HTML/CSS/Flexbox

Community feedback

• 

  P

  Harm Intemann•590

  @ghintemaPosted over 2 years ago

  Hi, I've just had a glance at your code and these are the things that rose my interest:

  • You should put your prices in an extra <p>-tag. It's more semantical.

  • there is an empty <div class="card-img"></div>. Supose you did that to give it a background-image. I think (and I'd suggest) its better standard to put an <img>-tag here. Espacially because it's a product-presentation and therefore semantical - and not only pure design. For desktop you can still exchange it anyway via css by setting the .card-img { content: url("") }. But this way you can add <img alt="description of picture"> wich improves accessibility...

  Marked as helpful

  1