@correlucas
Posted
👾Hi Markus, congrats on completing this challenge!
Amazing solution! I’ve just opened the solution’s live site and I liked the job you’ve done a lot. I’ve some suggestions for you:
You've done the design for the wrong image, when you download the starter files the folder comes with 3 files (preview card, desktop and mobile) you've created the solution based on the preview
and you should consider only the mobile + desktop images
.
Remove the background-color
from the container and add it to the body
to make sure this color background will display it full screen.
Something you can do to improve the image that needs to change between mobile and desktop is to use <picture>
instead of <img>
wrapped in a div. You can manage both images inside the <picture>
tag and use the html to code to set when the images should change setting the device max-width
depending of the device (phone / computer) Here’s a guide about how to use picture
: https://www.w3schools.com/tags/tag_picture.asp
✌️ I hope this helps you and happy coding!
Marked as helpful