Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product preview card component using html/css

@costaguh

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Lucas 👾 104,420

@correlucas

Posted

Aqui Gustavo mais uma dica pra vc

Quando esse componente vai ficando mto pequeno o texto começa a ficar muito colado, um jeito de melhorar isso é fazer com que a parte dos preços fiquem em linhas diferentes depois de uma determinada largura, por exemplo essa media query que apliquei pro seu código:

@media (max-width: 350px) {
.price {
    font-family: "Fraunces", serif;
    font-size: 1.875rem;
    margin-top: 1.25em;
    display: flex;
    align-items: flex-start;
    color: var(--primary-dark-cyan);
    flex-direction: column;
}
}

Pra reduzir o seu código e deixar o arquivo de CSS muito leve e melhorar o carregamento da página você pode usar essa ferramenta chamada CSS Minify que reduz o código css removendo caracteres desnecessários. https://www.toptal.com/developers/cssminifier

Marked as helpful

1

@VCarames

Posted

Hey @costaguh, great job on this project!

Some suggestions to improve you code:

  • When using different sized images for responsiveness, it’s far more efficient to use the <picture> element.
  <picture>
    <source media="(min-width: )" srcset="">
    <img src="" alt="">
  </picture>

https://web.dev/learn/design/picture-element/

  • For media queries, I definitely suggest using em for them. By using px your assuming that every users browser (mobile, tablet, laptop/desktop) is using a font size of 16px (this is the default size on browser). Em's will help with users whose default isn't 16px, which can sometimes cause the your content to overflow and negatively affect your layout.

Happy Coding!

Marked as helpful

1

@costaguh

Posted

@vcarames I fixed the errors, thanks!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord