Design comparison
Solution retrospective
All feedback is welcome
Community feedback
- @amalkarimPosted about 2 years ago
Hi Rupom,
Actually your solution is good enough and I have nothing to say about it. It's only one little detail about the
body
. When you give itheight: 100vh;
, it means it will stay that way even though the content is taller than that. Try access the solution page using mobile phone in landscape mode, some parts of the preview card will be unseen and we can't scroll to see them. Instead, we need the body to have the minimum height of 100vh, and can grow if necessary. So, instead ofheight: 100vh;
, usemin-height: 100vh;
.I'm sorry for the long text, when in reality it only says about one thing ha3.
Happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord