Product preview card component using HTML CSS (flex box)

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • You already using Flexbox for layout, but you didn't utilized it's full potential. Just add the following rules to properly center the component.

  ---

  body {
    display: flex;
    justify-content-center;
    align-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  .content {
    margin: auto;
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  Felice Nicolas Barcellona•490

  @feliceNicolasBarcellonaPosted over 1 year ago

  It is good practice to separate CSS code from HTML code (separation of concerns). Therefore, I recommend creating a file, for example, styles.css and moving all the CSS code there, and then linking it inside the head section.

  0