Design comparison
SolutionDesign
Community feedback
- @oshaxgioPosted about 1 year ago
great job, i'm new to giving feedback but let's try
I would give the class="text" a maximum width of 300px instead of giving each of its children a maximum width. Then, I would play around with the paddings.
I noticed that you used <source> for the image and provided a fail-safe in the form of an <img> tag if the device won't load using the <source> tag, but you only gave a fail-safe for the mobile picture and not for the desktop. Instead of using fail-safes, I would use an <img> tag and make them display interchangeably using @media queries.
i hope this helps
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord