Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product Preview Card Component Using Grid

@Anusha-Syeda012

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I have written the code using modern CSS, and I would appreciate your valuable feedback.

Community feedback

Bryan Li 3,550

@Zy8712

Posted

Your site looks pretty good on desktop. Some things I feel you should add/change:

  • using <main> tags around your page's main content. This is for accessibility purposes
  • centering you component using flexbox instead of using the margin: 5rem. Doing so would require you to use display: flex on the parent container which in this case is the body. So your code could look something like this:
body {
    min-height: 100vh;
    display: flex;
    flex-direction: column;
    justify-content: center;
    align-items: center;
}
  • one last thing I feel you should add in is mobile responsiveness so your site looks good for smaller screen sizes. To learn more about media queries and mobile responsiveness you can read this and this.

Hope you find this feedback userful 👍

0

@Anusha-Syeda012

Posted

Thanks @Zy8712 for your valuable feedback, and yes i will add/modify this

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord