Product Preview Card Component Using Grid

Community feedback

• 

  Bryan Li•3,530

  @Zy8712Posted 12 months ago

  Your site looks pretty good on desktop. Some things I feel you should add/change:

  • using <main> tags around your page's main content. This is for accessibility purposes
  • centering you component using flexbox instead of using the margin: 5rem. Doing so would require you to use display: flex on the parent container which in this case is the body. So your code could look something like this:

  body {
      min-height: 100vh;
      display: flex;
      flex-direction: column;
      justify-content: center;
      align-items: center;
  }
  

  • one last thing I feel you should add in is mobile responsiveness so your site looks good for smaller screen sizes. To learn more about media queries and mobile responsiveness you can read this and this.

  Hope you find this feedback userful 👍

  0

  ---

  

  Anusha Syeda•90

  @Anusha-Syeda012Posted 12 months ago

  Thanks @Zy8712 for your valuable feedback, and yes i will add/modify this

  0