Design comparison
Solution retrospective
Got a lot of issues fixed I had with the previous exercises, especially my structuring and design choices. Also, incorporated CSS variables into this one which actually helped in reducing the time spent, for example, in looking for the appropriate colors for texts, backgrounds.
Do comment on my Code and design, would love to hear feedback.
Community feedback
- @legion40216Posted over 1 year ago
Hi, Its pretty neat work... couple of problems i think the image is part of the document so it shouldnt be added as an background image. The card should have gotten the max-width property, and most of the classes are unnecessary instead use the classes to style the product page.
0@Terminal239Posted over 1 year ago@legion40216 Thanks for the feedback! Will fix the problem with the image and the max-width. For the classes thing, I learnt this from a course in which the instructor encouraged the use of class names for the elements.
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord