product preview card component using flexbox

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component.

  body {
      min-height: 100vh;
      display: grid;
      place-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  .container {
    margin: 80px auto;
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  Panji•2,090

  @pperdanaPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  I have feedback on your code, to solve it you can try

  in style.css, on your image-container and right selector update the width with static value instead of using unit %, for example the width value is 250px

  image-container berfore

  .image-container {
    height: 20%;
    width: 20%;
  }
  

  image-container after

  .image-container {
    height: 20%;
    width: 250px;
  }
  

  right before

  .right {
    background-color: hsl(0, 0%, 100%);
    height: 20%;
    width: 20%;
    padding-left: 20px;
    padding-right: auto;
    /* padding-bottom: 10px; */
    border-top-right-radius: 4px;
    border-bottom-right-radius: 4px;
    /* margin: 0; */
  }
  

  right after

  .right {
    background-color: hsl(0, 0%, 100%);
    height: 20%;
    width: 250px;
    padding-left: 20px;
    padding-right: auto;
    /* padding-bottom: 10px; */
    border-top-right-radius: 4px;
    border-bottom-right-radius: 4px;
    /* margin: 0; */
  }
  

  I hope you find it useful! 😄

  Happy coding🤖

  Marked as helpful

  0