Melvin Aguilar ๐ง๐ปโ๐ปโข 61,220
@MelvinAguilar
Posted
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
ARIA ๐:
div
elements are not interactive, so they do not require a label, and they do not work on div elements; if you use a screen reader, you will notice that no aria-label with the div, section, or main tags is announced.
- The
aria-label
attributes are not required for paragraphs because the text content of the p and h1 elements is already accessible to screen readers. When the aria-label attribute is applied to a paragraph element, screen reader users will hear the text specified in the attribute's value rather than the text of the paragraph.
aria-label="Add to cart"
: Don't repeat what the cart button says in the HTML; if you change the text of the button, it's very likely that the aria-label attribute will be forgotten to update.
- One component is not a complete page, there should not be a <header> and <footer> in the solution.
I hope you find it useful! ๐
Happy coding!
Marked as helpful
1