Product preview card component using CSS Grid, BEM and CSS Variables

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  BODY MEASUREMENTS 📐:

  • Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation.

  ---

  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

  ---

  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  2

  ---

  

  Steve•1,170

  @peanutbutterjllyPosted over 1 year ago

  @0xAbdulKhalid

  very good point and nice tip.

  I almost always learn from the advice that you give, keep it up there.

  0
• 

  Steve•1,170

  @peanutbutterjllyPosted over 1 year ago

  First off, let me say your solution looks great!

  As far as Flexbox or Grid, it really comes down to your personal preference in my opinion.

  I tend to use Grid to layout the page and Flex on smaller 'components' (think nav-bars, footers, cards, etc.) but it really comes down to what you feel more comfortable with.

  With great browser support for both tools, you can use either freely.

  Good job with this challenge and good question!

  Marked as helpful

  0
• 

  Mukwende•1,370

  @mukwende2000Posted over 1 year ago

  Flexbox is prefered here, grid is for more complex layout, 2d layouts to be precise.

  0