Product Preview Card Component Using CSS Grid

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • You already using Grid for layout, but you didn't utilized it's full potential. Just add the following rule to properly center the component.

  ---

  body {
  min-height: 100vh;
  }
  

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  Ukaegbu Gray Nneji•220

  @graynnejiPosted over 1 year ago

  Using display: inline-flex on the picture tag to remove unnecessary white space is a valid solution. However, there might be a better way to approach it depending on the specific use case and design requirements.

  One possible alternative solution is to set the height of the picture tag to 100%, and then use object-fit: cover on the img element inside the picture tag. This will ensure that the image fills the available height of the picture tag without distorting its aspect ratio. Here's an example:

  <picture style={{ height: "100%" }}> <img srcSet="image-small.jpg 480w, image-medium.jpg 768w, image-large.jpg 1200w" sizes="(max-width: 600px) 480px, (max-width: 768px) 768px, 1200px" src="image-large.jpg" alt="Alt Text" style={{ objectFit: "cover", width: "100%", height: "100%" }} /> </picture>

  With this approach, you can avoid using display: inline-flex and rely on CSS properties specifically designed for handling images, such as object-fit. This can make your code more readable and maintainable, and also help ensure that your images display correctly across different devices and screen sizes.

  I hope this helps!

  Marked as helpful

  0

  ---

  

  amrajat•170

  @amrajatPosted over 1 year ago

  @graynneji I tried object-fit: cover without giving picture tag height 100% now i got to know why it was not working. Thanks for your valuable feedback

  0