Product Preview Card Component Using CSS Grid and Flexbox

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 🏷️:

  • Wrap the page's whole main content in the <main> tag.

  • The alt attribute is used to provide a text description of the image which is useful for screen reader users, assistive technology users, and search engine optimization. Improve the alt attribute to the <img> tag of the product.

  • The element <span class="button_text"> inside the button is unnecessary, you can have text directly inside the button without a problem.

  • It is recommended to use CSS to apply styles such as bold text, rather than the "b" tag. The font-weight: bold; property is used to make the text bold.

  CSS 🎨:

  • You don't need to add font-family: 'Montserrat', sans-serif; to each <p>, <h*> separately. Instead, add it to body.

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. Resource 📘.

  • To center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📘.

  CSS Reset 🔄:

  • You should use a CSS reset. A CSS reset is a set of CSS rules that are applied to a webpage in order to remove the default styling of different browsers.

    CSS resets that are widely used:

    • Reset CSS
    • "My Custom CSS Reset" by JoshWComeau

  I hope you find it useful! 😄

  Happy coding!

  0