Design comparison
Community feedback
- @VCaramesPosted about 2 years ago
Hey @kylejrhoden, some suggestions to improve you code:
-
Your image needs an Alt Tag. Inside the alt tag should describe what the image is; they need to be readable. Assume you’re describing the image to someone.
-
The picture element is being used Incorrectly. This is how it suppose to be:
Syntax:
<picture> <source media="(min-width: )" srcset=""> <img src="" alt=""> </picture>
More Info:
https://www.w3schools.com/html/html_images_picture.asp
https://web.dev/learn/design/picture-element/
-
There is only one heading in this challenge and that is the name of the perfume, “Gabrielle Essence Eau De Parfum”.
-
The old price 🏷 is not being announced properly to screen readers. You want to wrap it in a Del Element and include a sr-only text explaining that this is the old price.
-
You are using the Article Elements incorrectly.
-
You need to give your elements classes, to make it easier to edit.
Happy Coding! 👻🎃
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord