Product preview card component using css

Community feedback

• 

  Lucas 👾•104,300

  @correlucasPosted about 2 years ago

  👾Hello Amulya Prakash, Congratulations on completing this challenge!

  Your solution its almost done and I’ve some tips to help you to improve it:

  1.Its not so good that you used overflow: hidden for the whole content, in this case this property is making the content get cropped when the component gets tiny. Instead of using overflow to make the rounded borders use border-radius for each card.

  2.Use units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices.

  To save your time you can code your whole page using px and then in the end use a VsCode plugin called px to rem here's the link → https://marketplace.visualstudio.com/items?itemName=sainoba.px-to-rem to do the automatic conversion or use this website https://pixelsconverter.com/px-to-rem

  3.A better way to work this solution image, the product image is by using <picture> to wrap it on the html instead of using it as <img> or background-image (with the css). Using <picture> you wrap both images (desktop and mobile) and have more control over it, since you can set in the html when the images changes setting the screen size for each image.ote that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image.

  Here’s the documentation and the guide to use this tag: https://www.w3schools.com/tags/tag_picture.asp

  See the example below:

  <picture>
    <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
    <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
  </picture>
  

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1

  ---

  

  Amulya Prakash•800

  @amulyalovescodingPosted about 2 years ago

  Hi, @correlucas Thanks for providing me valuable tips, I will surely implement from now on.

  Actually i have tried to use <picture> earlier but it doesn't worked because I screwed-up in style="width:auto;.

  Thanks for pointing it out.

  Please don’t hesitate to guide me again. Thanks again for giving me this information.

  0