Design comparison
Community feedback
- @HassiaiPosted almost 2 years ago
Replace<div class="container">with the main tag the first <h2> with <h1> and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html
To center .container on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.
in the media query for the desktop design, increase the padding value for .text, and remove the height value of .container. the padding value for .text will be a good replacement of that.
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0@Arun12MuralidharanPosted almost 2 years ago@Hassiai
Thanks a lot for your inputs. I will follow this. I'm new to HTML / CSS, definetly your inputs will make me learn more. Thanks again.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord