Some struggle with image sizing responsiveness.
@fersrm
Posted
al body le falta min-height: 100vh; para que se pueda alinear verticalmente, para el contendedor de la card es mejor usar la etiqueta main por temas de estructura de una página no puedes tener más de un h1 por página para
<h3 class="past-price">$169.99</h3> puedes usar mejor la etiqueta span yo personalmente uso esta pagina: "https://validator.w3.org/nu/#textarea" para verificar la estructura del htmlMarked as helpful
@Hassiai
Posted
Replace <div class="card"> with the main tag, <h2> with <h1> and <div class="attribution"> with the footer tag to fix the accessibility issue. click here for more on web-accessibility and semantic html
In the media query, give .card a max-width value instead of a width value and add grid-template-rows: 17rem 17rem. give the picture grid-row: 1 and .info grid-row: 2
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
