バレンタイン 😈• 64,190
@VCarames
Posted
Hey there! 👋 Here are some suggestions to help improve your code:
- Do not forget ⚠️ to check your FEM report, to see what is incorrect and update your code with it right after you submit your challenge.
- Since the images in this component add value and serve a purpose (displaying the product) it needs to be accessible ⚠️. The image needs to be applied using the
pictureelement and not thebackground-imageproperty, as it will not only let you use different images during different breakpoints it will let apply analt tagdescription to image stating what the image is.
- The only heading ⚠️ in this component, is the name of the perfume; “Gabrielle Essence Eau De Parfum” . The rest of the text should be wrapped in a
paragraphelement.
- Currently, the old price (169.99) 🏷 is not being properly announced 😢 to screen readers. To fix this, you are going to wrap the the price in a
delelement and inside it you will add aspanelement with ansr-only classthat will state something like “The previous price was…” and use CSS to make it only visible to screen readers.
More Info:📚
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
Marked as helpful
0
バレンタイン 😈• 64,190
@VCarames
Posted
- Your
CSS Resetis being underutilized. 😢 To fully maximize 💯 it, you will want to add more to it.
Here are some examples that you can freely use:
- For improved accessibility 📈 for your content, it is best practice to use
emformedia-queries. Using this unit gives users the ability to scale elements up and down, relative to a set value.
Marked as helpful
0
Mariana Rainha• 50
@marianarainha
Posted
@vcarames thank you for your review and suggestions, that's very kind ! I'll make those changes.
0
