Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product preview card component

DaftEndev 80

@DaftEndev

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Lucas 👾 104,420

@correlucas

Posted

👾Hello @DaftEndev, Congratulations on completing this challenge!

Your solution its almost done and I’ve some tips to help you to improve it:

Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

See the example below:

<picture>
  <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
  <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
</picture>

👨‍💻Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/product-preview-card-vanilla-css-and-custom-hover-state-on-hero-85A1JsueD1

✌️ I hope this helps you and happy coding!

Marked as helpful

1

DaftEndev 80

@DaftEndev

Posted

Hello @correlucas! Thanks for these tips! I had actually totally forgotten to make the page responsive for mobile. 🤦‍♂️ It's now done, I updated the repository. I used another technique of declaring the two images with <img> tags, then display:none or display:block those images depending on the format.

I don't know if it's better, but I'll try the <picture> tag for my next challenges.

PS: sorry for my poor english

0
Adriano 34,090

@AdrianoEscarabote

Posted

Hi DaftEndev, how are you?

I really liked the result of your project, but I have some tips that I think you will enjoy:

  • images must have alt text unless it is a decorative image, for any decorative image each IMG tag must have empty alt="" and add aria-hidden="true" attributes to make all the assistive technologies of the Web, as screen reader. Learn the differences between decorative/meaningless images vs important content.
  • To align some content in the center of the screen, always prefer to use display: flex; it will make the layout more responsive!

Example:

body {
    margin: 0;
    padding: 0;
    display: flex;
    align-items: center;
    justify-content: center;
    min-height: 100vh;
}

The rest is great!

I hope it helps... 👍

Marked as helpful

0

DaftEndev 80

@DaftEndev

Posted

Hello @AdrianoEscarabote. I actually forgot to add alt text, I have to get in the habit of doing it! I didn't know about aria-hidden, I'll find out about that. Thanks for these tips!

0
Adriano 34,090

@AdrianoEscarabote

Posted

@DaftEndev no problem, keep coding!!

0

@FlaviuD94

Posted

Hi @DaftEndev, you did a nice work on this project😀. I have some suggetions for you to improve your code: 📝when using img tag don't forget to add alt text. 📝try to use section tag online for sections of your code, like this project could be integrate in a section, and inside use div for block elements and span for inline elements. 📝you can eliminate the code that is not related to your project.

Keep up the good work and enjoy coding!

Marked as helpful

0

Tea 90

@TeaChareqishvili

Posted

@FlaviuD94 hi :)) thanks for your feedback :)))

0
DaftEndev 80

@DaftEndev

Posted

Hello @FlaviuD94. Thank you for your feedback, I indeed forgot to add alt text, I really need to get used to it! I won't forget in my next challenges. I hadn't thought about the potential integrations on a page, it's true that in this case the <section> tags are misused. I will work on it!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord