バレンタイン 😈• 64,190
@VCarames
Posted
Hey there! 👋 Here are some suggestions to help improve your code:
- Do not forget ⚠️ to check your FEM report, to see what is incorrect and update your code with it right after you submit your challenge.
- The
sectionis being used incorrectly ❌ and not needed for this challenge.
- The image’s
alt tagdescription needs to be improved upon ⚠️. Assume that you are describing the image to a someone over the phone.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- This component requires the use of two images 🎑 at different breakpoints ⚠️. The
pictureelement will facilitate this.
Syntax:
<picture>
<source media="(min-width: )" srcset="">
<img src="" alt="">
</picture>
More Info:📚
https://www.w3schools.com/html/html_images_picture.asp
- Do not uppercase ❌ "perfume" in HTML as it is not accessible friendly. Instead you will want to style it in CSS.
- The only heading ⚠️ in this component, is the name of the perfume; “Gabrielle Essence Eau De Parfum” . The rest of the text should be wrapped in a
paragraphelement.
- Currently, the old price (169.99) 🏷 is not being properly announced 😢 to screen readers. To fix this, you are going to wrap the the price in a
delelement and inside it you will add aspanelement with ansr-only classthat will state something like “The previous price was…” and use CSS to make it only visible to screen readers.
More Info:📚
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
0
バレンタイン 😈• 64,190
@VCarames
Posted
- A lot of styling updates ⚠️ are still needed to better match the FEM design.
- To properly center ✅ your content to your page, you will want to add the following to your
body(this method uses CSS Grid):
body {
min-height: 100vh;
display: grid;
place-content: center;
}
More Info: 📚
- Add a
border-radiusto your component’s container along withoverflow: hidden.
- Implement a "Mobile First" approach 📱 > 🖥
Mobile devices are now the dominant 👑 way in which people browse the web, it is critical that your website/content looks perfect on all mobile devices.
More Info: 📚
- For improved accessibility 📈 for your content, it is best practice to use
remfor yourfont-sizeand other property values. Whileemis best formedia-queries. Using these units gives users the ability to scale elements up and down, relative to a set value.
0
