Product preview card component Solution Using HTML and CSS
Design comparison
Solution retrospective
I would really appreciate any feedback. I struggled a little bit with really grasping the concept of responsive design but I think there is much more to learn. Are there any best practices I should have followed? Thank you in advance for your feedback
Community feedback
- @MelvinAguilarPosted 12 months ago
Hello there π. Good job on completing the challenge !
I like this solution; it incorporates semantic tags and utilizes styles effectively. I have some suggestions about your code that might interest you.
- Prefer
min-height: 100vh
overheight
to prevent component cutoff on smaller screens.
- Use the
<del>
tag for indicating discounted prices.
- Avoid redundant terms in
alt
attributes like "image," "photo," or "picture" since the image tag implies this information.
- For non-informative images like the cart-icon, use an empty
alt
attribute. Learn more here π. Further insights on thealt
attribute in this article π.
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding!
Marked as helpful0@maryanne4jcPosted 12 months ago@MelvinAguilar Thank you so much. Your feedback is definitely helpful and I appreciate it.
1 - Prefer
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord