Product preview card component solution using flexbox

Community feedback

• 

  Ahmed El_Bald•1,020

  @Ahmed-ElbaldPosted over 2 years ago

  Hey Mateus,

  Concerning the design itself, it's great. But u have some issues with accessibility:

  • You have more than one ‹main› in the page and it should be unique.

  • I think u also have more than an element that shares the same id. Try to avoid that

  • The attribution section is causing some issues. Delete it or wrap it by a landmark

  Marked as helpful

  1

  ---

  

  Mateus Moura Domingos•140

  @Theuz1nh0Posted over 2 years ago

  @Ahmed-Elbald Hi, thank you very much for the feedback

  • The <main> tag problem if repeated twice I managed to solve it, I changed the second <main> tag to a <div> tag, thanks, but here in the solution the problem still says it has two <main> tags, I have to repost my solution?
  • And about the id being shared in more than one element, I looked in my code and didn't find it.
  • I didn't understand that last thing you said, sorry.

  0

  

  Ahmed El_Bald•1,020

  @Ahmed-ElbaldPosted over 2 years ago

  @Theuz1nh0

  • After making ur changes u have to make a new report. To do that, hit the view report button and then hit the red make a new report button

  • I didn't really look at the code l, I saw the accessibility report and it says that an id is being shared

  • There is a div.attribution in ur solution (the one that contains attribution for frontend mentor). It's causing issues

  Marked as helpful

  1
• 

  Mateus Moura Domingos•140

  @Theuz1nh0Posted over 2 years ago

  @ Ahmed-Elbald

  • Wow, thank you very much, too bad I only saw your answer after I made another publication of the same project hahaha, but I managed to generate the new report, thank you very much. About div.attribution <a href="https://www.frontendmentor.io?ref=challenge"... `, I think I get it now, I will solve this problem, thanks again

  0

  ---

  

  Ahmed El_Bald•1,020

  @Ahmed-ElbaldPosted over 2 years ago

  @Theuz1nh0 You're welcome

  0