@tobezhanabi
Posted
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
I have other recommendations regarding your code that I believe will be of great interest to you. HTML 🏷️:
In your solution, you have a Main tag and still used <div class="container>, there is no need for the div class as main tag mean the same thing. Also, the <div class="attribution"> should be replaced with semantic element <footer> in your index.html file to improve accessibility and organization of your page.
What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span> They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page
HEADINGS ⚠️: h1 to h6 follow hierarchy, in your code the heading level following an h1 element should be an h2 element, not an h3 element. I hope you find it helpful ! 😄 Above all, the solution you submitted is great
Happy coding!
Marked as helpful
@aljager1983
Posted
@tobezhanabi wow thanks bro, im going to ammend my codes as per you recommendation and re-push in github, thanks a lot.
